ci(workflows): ternary GRADLE_USER_HOME for namespace runner#29791
Closed
jluque0101 wants to merge 1 commit into
Closed
ci(workflows): ternary GRADLE_USER_HOME for namespace runner#29791jluque0101 wants to merge 1 commit into
jluque0101 wants to merge 1 commit into
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
github-actions
Bot
added
the
pr-not-ready-for-e2e
Contributor
Author
|
Folded into #29780 — same logical scope (cross-provider plumbing for Workstream D), and both touched build-android-e2e.yml. Branch will be deleted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 follow-up — cross-provider env-var divergence not handled by Phase 0.
build-android-e2e.ymlhardcodesGRADLE_USER_HOME: /home/admin/_work/.gradle— that path is the Cirruscirruslabs/ubuntu-runner-amd64runner's home (useradmin). On Namespace runners the user isrunner, so Gradle fails to create the lock-file directory.This PR ternaries the env var on
runner_provider, mirroring Phase 0'sruns-onternary pattern:Behaviour on
runner_provider: currentis byte-identical (the second branch returns the original Cirrus path).Validated end-to-end on the integration-test branch: https://github.com/MetaMask/metamask-mobile/actions/runs/25435437017 (Build Android APKs ✓ in 20m56s, all 26 Android E2E smoke jobs ✓).
Note
Low Risk
Low risk CI-only change that adjusts a Gradle cache path to match the user home on Namespace runners; behavior on the existing Cirrus runner remains the same.
Overview
Updates the
build-android-e2e.ymlworkflow to setGRADLE_USER_HOMEvia arunner_providerconditional, using/home/runner/_work/.gradleon Namespace runners and preserving the existing/home/admin/_work/.gradlepath on the Cirrus runner.This prevents Gradle failures on Namespace due to an incorrect home directory while keeping the current provider behavior unchanged.
Reviewed by Cursor Bugbot for commit a22e192. Bugbot is set up for automated code reviews on this repo. Configure here.